Conversation
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
|
Removed unused parameter because ruff was complaining |
lispandfound
requested review from
AndrewRidden-Harper,
claudio525,
Copilot,
joelridden and
sungeunbae
There was a problem hiding this comment.
Pull request overview
This PR modernizes the PyPI publication workflow to support Rust extensions by adding cross-platform wheel building for macOS, Windows, and Linux. It also removes a deprecated parameter from the pseudo_spectral_acceleration function that is no longer needed due to changes in memory management handled by the Rust parallel work scheduler (Rayon).
Changes:
- Restructured GitHub Actions workflow to build platform-specific wheels using cibuildwheel for Python 3.12, 3.13, and 3.14
- Added Rust toolchain setup for all platforms with proper configuration for Linux containers
- Removed unused
psa_rotd_maximum_memory_allocationparameter and its documentation from thepseudo_spectral_accelerationfunction
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/publish-PyPI.yml | Split build job into separate wheel building (multi-platform) and sdist building jobs; configured cibuildwheel to build for multiple Python versions and architectures with Rust support |
| IM/ims.py | Removed unused psa_rotd_maximum_memory_allocation parameter and the now-unnecessary Optional import from typing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Makes some changes to PyPI publication script to:
So wheels now exist for all 9 combinations of those operating systems and python versions. This is a necessary pre-requisite for the next release given it now includes a rust extension.